Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile libsass for one platform at a time #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Compile libsass for one platform at a time #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f27e5cf
Compile libsass for one platform at a time
am11 Jan 19, 2017
55fa474
Sort usings
am11 Jan 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LibSass.NET.Tests/LibSass.NET.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
</Target>
<Target Name="AfterBuild">
<Copy
SourceFiles="$(LibSassPath)libsass32.dll;$(LibSassPath)libsass64.dll"
SourceFiles="$(LibSassPath)libsass.dll"
DestinationFolder="$(OutputPath)"
SkipUnchangedFiles="true" />
</Target>
Expand Down
4 changes: 2 additions & 2 deletions LibSass.NET.Tests/Spec/SpecTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
using System.Text.RegularExpressions;
using LibSass.Compiler.Options;
using Xunit;
using static LibSass.Tests.TestCommonsAndExtensions;
using static System.IO.Path;
using static System.IO.File;
using static System.IO.Path;
using static LibSass.Tests.TestCommonsAndExtensions;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can probably be undone. Nothing wrong with the sort, just not related to the changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, I ran batch formatter at the end of changes and this one was odd one out. All the rest of the code files in entire repo have usings sorted by same rule. We can do these changes separately if you prefer?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't really worry about it, but I'd usually just throw it in another commit for clarity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, this change is now part of a separate commit.


namespace LibSass.Tests.Spec
{
Expand Down
Loading