Merge pull request #1518 from sass/selector-extend

Add specs for selector-extend()
sass · Feb 28, 2020 · 0683abe · 0683abe
2 parents 78bd962 + 85494b1
commit 0683abe
Show file tree

Hide file tree

Showing 17 changed files with 2,046 additions and 0 deletions.
diff --git a/spec/core_functions/selector/extend/README.md b/spec/core_functions/selector/extend/README.md
@@ -0,0 +1,7 @@
+Much of the complexity in the algorithm for extend comes from determining which
+selectors are superselectors of which others and unifying two selectors, which
+are covered more explicitly by specs for the `is-superselector()` and
+`selector-unify()` functions, respectively. To avoid unnecessary duplication,
+the specs for `selector-extend()` itself don't thoroughly exercise the
+superselector or unification logic, and instead focuses on behavior that's
+specific to the full extension process.
diff --git a/spec/core_functions/selector/extend/complex.hrx b/spec/core_functions/selector/extend/complex.hrx
@@ -0,0 +1,87 @@
+<===> parent/without_grandparent/simple/input.scss
+a {b: selector-extend(".c .d", ".c", ".e")}
+
+<===> parent/without_grandparent/simple/output.css
+a {
+  b: .c .d, .e .d;
+}
+
+<===>
+================================================================================
+<===> parent/without_grandparent/complex/input.scss
+a {b: selector-extend(".c .d", ".c", ".e .f")}
+
+<===> parent/without_grandparent/complex/output.css
+a {
+  b: .c .d, .e .f .d;
+}
+
+<===>
+================================================================================
+<===> parent/without_grandparent/list/input.scss
+a {b: selector-extend(".c .d", ".c", ".e, .f")}
+
+<===> parent/without_grandparent/list/output.css
+a {
+  b: .c .d, .e .d, .f .d;
+}
+
+<===>
+================================================================================
+<===> parent/with_grandparent/simple/input.scss
+a {b: selector-extend(".c .d .e", ".d", ".f")}
+
+<===> parent/with_grandparent/simple/output.css
+a {
+  b: .c .d .e, .c .f .e;
+}
+
+<===>
+================================================================================
+<===> parent/with_grandparent/complex/input.scss
+a {b: selector-extend(".c .d .e", ".d", ".f .g")}
+
+<===> parent/with_grandparent/complex/output.css
+a {
+  b: .c .d .e, .c .f .g .e, .f .c .g .e;
+}
+
+<===>
+================================================================================
+<===> parent/with_grandparent/list/input.scss
+a {b: selector-extend(".c .d .e", ".d", ".f, .g")}
+
+<===> parent/with_grandparent/list/output.css
+a {
+  b: .c .d .e, .c .f .e, .c .g .e;
+}
+
+<===>
+================================================================================
+<===> trailing_combinator/child/input.scss
+a {b: selector-extend(".c .d", ".c", ".e >")}
+
+<===> trailing_combinator/child/output.css
+a {
+  b: .c .d, .e > .d;
+}
+
+<===>
+================================================================================
+<===> trailing_combinator/sibling/input.scss
+a {b: selector-extend(".c .d", ".c", ".e ~")}
+
+<===> trailing_combinator/sibling/output.css
+a {
+  b: .c .d, .e ~ .d;
+}
+
+<===>
+================================================================================
+<===> trailing_combinator/next_sibling/input.scss
+a {b: selector-extend(".c .d", ".c", ".e +")}
+
+<===> trailing_combinator/next_sibling/output.css
+a {
+  b: .c .d, .e + .d;
+}
diff --git a/spec/core_functions/selector/extend/error.hrx b/spec/core_functions/selector/extend/error.hrx
@@ -0,0 +1,291 @@
+<===> selector/parent/input.scss
+a {b: selector-extend("&", "c", "d")}
+
+<===> selector/parent/error
+Error: $selector: Parent selectors aren't allowed here.
+  ,
+1 | &
+  | ^
+  '
+  - 1:1  root stylesheet
+  ,
+1 | a {b: selector-extend("&", "c", "d")}
+  |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  '
+  input.scss 1:7  root stylesheet
+
+<===> selector/parent/error-libsass
+Error: Parent selectors aren't allowed here.
+        on line 1:23 of input.scss, in function `selector-extend`
+        from line 1:7 of input.scss
+>> a {b: selector-extend("&", "c", "d")}
+
+   ----------------------^
+
+<===>
+================================================================================
+<===> selector/invalid/input.scss
+a {b: selector-extend("[c", "d", "e")}
+
+<===> selector/invalid/error
+Error: $selector: expected more input.
+  ,
+1 | [c
+  |   ^
+  '
+  - 1:3  root stylesheet
+  ,
+1 | a {b: selector-extend("[c", "d", "e")}
+  |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  '
+  input.scss 1:7  root stylesheet
+
+<===> selector/invalid/error-libsass
+Error: invalid operator in attribute selector for c
+        on line 1:24 of input.scss, in function `selector-extend`
+        from line 1:7 of input.scss
+>> a {b: selector-extend("[c", "d", "e")}
+
+   -----------------------^
+
+<===>
+================================================================================
+<===> selector/type/options.yml
+---
+:todo:
+- sass/libsass#2964
+
+<===> selector/type/input.scss
+a {b: selector-extend(1, "c", "d")}
+
+<===> selector/type/error
+Error: $selector: 1 is not a valid selector: it must be a string,
+a list of strings, or a list of lists of strings.
+  ,
+1 | a {b: selector-extend(1, "c", "d")}
+  |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  '
+  input.scss 1:7  root stylesheet
+
+<===>
+================================================================================
+<===> extendee/parent/input.scss
+a {b: selector-extend("c", "&", "d")}
+
+<===> extendee/parent/error
+Error: $extendee: Parent selectors aren't allowed here.
+  ,
+1 | &
+  | ^
+  '
+  - 1:1  root stylesheet
+  ,
+1 | a {b: selector-extend("c", "&", "d")}
+  |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  '
+  input.scss 1:7  root stylesheet
+
+<===> extendee/parent/error-libsass
+Error: Parent selectors aren't allowed here.
+        on line 1:28 of input.scss, in function `selector-extend`
+        from line 1:7 of input.scss
+>> a {b: selector-extend("c", "&", "d")}
+
+   ---------------------------^
+
+<===>
+================================================================================
+<===> extendee/complex/options.yml
+---
+:todo:
+- sass/libsass#3066
+
+<===>
+================================================================================
+<===> extendee/complex/string/input.scss
+a {b: selector-extend("c", "d e", "f")}
+
+<===> extendee/complex/string/error
+Error: Can't extend complex selector d e.
+  ,
+1 | a {b: selector-extend("c", "d e", "f")}
+  |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  '
+  input.scss 1:7  root stylesheet
+
+<===>
+================================================================================
+<===> extendee/complex/list/input.scss
+a {b: selector-extend("c", d e, "f")}
+
+<===> extendee/complex/list/error
+Error: Can't extend complex selector d e.
+  ,
+1 | a {b: selector-extend("c", d e, "f")}
+  |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  '
+  input.scss 1:7  root stylesheet
+
+<===>
+================================================================================
+<===> extendee/invalid/input.scss
+a {b: selector-extend("c", "[d", "e")}
+
+<===> extendee/invalid/error
+Error: $extendee: expected more input.
+  ,
+1 | [d
+  |   ^
+  '
+  - 1:3  root stylesheet
+  ,
+1 | a {b: selector-extend("c", "[d", "e")}
+  |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  '
+  input.scss 1:7  root stylesheet
+
+<===> extendee/invalid/error-libsass
+Error: invalid operator in attribute selector for d
+        on line 1:29 of input.scss, in function `selector-extend`
+        from line 1:7 of input.scss
+>> a {b: selector-extend("c", "[d", "e")}
+
+   ----------------------------^
+
+<===>
+================================================================================
+<===> extendee/type/options.yml
+---
+:todo:
+- sass/libsass#2964
+
+<===> extendee/type/input.scss
+a {b: selector-extend("c", 1, "d")}
+
+<===> extendee/type/error
+Error: $extendee: 1 is not a valid selector: it must be a string,
+a list of strings, or a list of lists of strings.
+  ,
+1 | a {b: selector-extend("c", 1, "d")}
+  |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  '
+  input.scss 1:7  root stylesheet
+
+<===>
+================================================================================
+<===> extender/parent/input.scss
+a {b: selector-extend("c", "d", "&")}
+
+<===> extender/parent/error
+Error: $extender: Parent selectors aren't allowed here.
+  ,
+1 | &
+  | ^
+  '
+  - 1:1  root stylesheet
+  ,
+1 | a {b: selector-extend("c", "d", "&")}
+  |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  '
+  input.scss 1:7  root stylesheet
+
+<===> extender/parent/error-libsass
+Error: Parent selectors aren't allowed here.
+        on line 1:33 of input.scss, in function `selector-extend`
+        from line 1:7 of input.scss
+>> a {b: selector-extend("c", "d", "&")}
+
+   --------------------------------^
+
+<===>
+================================================================================
+<===> extender/invalid/input.scss
+a {b: selector-extend("c", "d", "[e")}
+
+<===> extender/invalid/error
+Error: $extender: expected more input.
+  ,
+1 | [e
+  |   ^
+  '
+  - 1:3  root stylesheet
+  ,
+1 | a {b: selector-extend("c", "d", "[e")}
+  |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  '
+  input.scss 1:7  root stylesheet
+
+<===> extender/invalid/error-libsass
+Error: invalid operator in attribute selector for e
+        on line 1:34 of input.scss, in function `selector-extend`
+        from line 1:7 of input.scss
+>> a {b: selector-extend("c", "d", "[e")}
+
+   ---------------------------------^
+
+<===>
+================================================================================
+<===> extender/type/options.yml
+---
+:todo:
+- sass/libsass#2964
+
+<===> extender/type/input.scss
+a {b: selector-extend("c", "d", 1)}
+
+<===> extender/type/error
+Error: $extender: 1 is not a valid selector: it must be a string,
+a list of strings, or a list of lists of strings.
+  ,
+1 | a {b: selector-extend("c", "d", 1)}
+  |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  '
+  input.scss 1:7  root stylesheet
+
+<===>
+================================================================================
+<===> too_many_args/input.scss
+a {b: selector-extend("c", "d", "e", "f")}
+
+<===> too_many_args/error
+Error: Only 3 arguments allowed, but 4 were passed.
+  ,--> input.scss
+1 | a {b: selector-extend("c", "d", "e", "f")}
+  |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ invocation
+  '
+  ,--> sass:selector
+1 | @function extend($selector, $extendee, $extender) {
+  |           ======================================= declaration
+  '
+  input.scss 1:7  root stylesheet
+
+<===> too_many_args/error-libsass
+Error: wrong number of arguments (4 for 3) for `selector-extend'
+        on line 1:7 of input.scss
+>> a {b: selector-extend("c", "d", "e", "f")}
+
+   ------^
+
+<===>
+================================================================================
+<===> too_few_args/input.scss
+a {b: selector-extend("c", "d")}
+
+<===> too_few_args/error
+Error: Missing argument $extender.
+  ,--> input.scss
+1 | a {b: selector-extend("c", "d")}
+  |       ^^^^^^^^^^^^^^^^^^^^^^^^^ invocation
+  '
+  ,--> sass:selector
+1 | @function extend($selector, $extendee, $extender) {
+  |           ======================================= declaration
+  '
+  input.scss 1:7  root stylesheet
+
+<===> too_few_args/error-libsass
+Error: Function selector-extend is missing argument $extender.
+        on line 1 of input.scss
+>> a {b: selector-extend("c", "d")}
+
+   ------^