Update tests for strict function unit deprecations #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goodwine
requested changes
Oct 28, 2022
spec/core_functions/color/mix.hrx
Outdated
| @@ -349,6 +391,16 @@ Error: argument `$weight` of `mix($color1, $color2, $weight: 50%)` must be a num | |||
| a {b: mix(red, blue, -0.001)} | |||
|
|
|||
| <===> error/bounds/too_low/error | |||
| DEPRECATION WARNING: $weight: Passing a number without unit % (-0.001) is deprecated. | |||
There was a problem hiding this comment.
The deprecation warning was already part of the tests above, is testing both warning + error intentional? If not, then I think it's better to add units so we don't emit both
Goodwine
approved these changes
Oct 28, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1813
See sass/sass#3374
[skip dart-sass]