issue-813 -- Adds unit tests

sasstools · Aug 25, 2016 · 75ac1f0 · 75ac1f0
1 parent d506b26
commit 75ac1f0
Show file tree

Hide file tree

Showing 6 changed files with 120 additions and 4 deletions.
diff --git a/lib/rules/no-domains.js b/lib/rules/no-domains.js
@@ -15,7 +15,7 @@ module.exports = {
           var stripped = helpers.stripQuotes(item.content),
               parsedUrl = url.parse(stripped, false, true);
 
-          if (parsedUrl.host) {
+          if (parsedUrl.host && parsedUrl.protocol !== 'data:') {
             result = helpers.addUnique(result, {
               'ruleId': parser.rule.name,
               'severity': parser.severity,

diff --git a/lib/rules/no-url-protocols.js b/lib/rules/no-url-protocols.js
@@ -8,7 +8,7 @@ var isUrlRegex = /^(https?:)?\/\//,
 module.exports = {
   'name': 'no-url-protocols',
   'defaults': {
-    'enforce-domains' : true
+    'enforce-domains': true
   },
   'detect': function (ast, parser) {
     var result = [];
@@ -20,8 +20,8 @@ module.exports = {
               regexSelector = parser.options['enforce-domains'] ?
                   isUrlRegex : noProtocolRegex,
               message = parser.options['enforce-domains'] ?
-                  "Protocols and domains in URLs are disallowed" :
-                  "Protocols in URLS are disallowed";
+                  'Protocols and domains in URLs are disallowed' :
+                  'Protocols in URLS are disallowed';
 
           if (stripped.match(regexSelector)) {
             result = helpers.addUnique(result, {

diff --git a/tests/rules/no-domains.js b/tests/rules/no-domains.js
@@ -0,0 +1,35 @@
+'use strict';
+
+var lint = require('./_lint');
+
+//////////////////////////////
+// SCSS syntax tests
+//////////////////////////////
+describe('no domains - scss', function () {
+  var file = lint.file('no-domains.scss');
+
+  it('enforce', function (done) {
+    lint.test(file, {
+      'no-domains': 1
+    }, function (data) {
+      lint.assert.equal(3, data.warningCount);
+      done();
+    });
+  });
+});
+
+//////////////////////////////
+// Sass syntax tests
+//////////////////////////////
+describe('no domains - sass', function () {
+  var file = lint.file('no-domains.sass');
+
+  it('enforce', function (done) {
+    lint.test(file, {
+      'no-domains': 1
+    }, function (data) {
+      lint.assert.equal(3, data.warningCount);
+      done();
+    });
+  });
+});
diff --git a/tests/rules/no-url-protocols.js b/tests/rules/no-url-protocols.js
@@ -16,8 +16,23 @@ describe('no url protocols - scss', function () {
       done();
     });
   });
+
+  it('allow protocol-relative urls [enforce-domains: false]', function (done) {
+    lint.test(file, {
+      'no-url-protocols': [
+        1,
+        {
+          'enforce-domains': false
+        }
+      ]
+    }, function (data) {
+      lint.assert.equal(2, data.warningCount);
+      done();
+    });
+  });
 });
 
+
 //////////////////////////////
 // Sass syntax tests
 //////////////////////////////
@@ -32,4 +47,18 @@ describe('no url protocols - sass', function () {
       done();
     });
   });
+
+  it('allow protocol-relative urls [enforce-domains: false]', function (done) {
+    lint.test(file, {
+      'no-url-protocols': [
+        1,
+        {
+          'enforce-domains': false
+        }
+      ]
+    }, function (data) {
+      lint.assert.equal(2, data.warningCount);
+      done();
+    });
+  });
 });
diff --git a/tests/sass/no-domains.sass b/tests/sass/no-domains.sass
@@ -0,0 +1,25 @@
+.foo
+  background-image: url('https://foo.com/img/bar.png')
+
+
+.foo
+  background-image: url('http://foo.com/img/bar.png')
+
+
+.foo
+  background-image: url('//foo.com/img/bar.png')
+
+
+.foo
+  background-image: url('/img/bar.png')
+
+
+.foo
+  background-image: url('img/bar.png')
+
+
+.foo
+  background-image: url('bar.png')
+
+.foo
+  background-image: url('data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7')
diff --git a/tests/sass/no-domains.scss b/tests/sass/no-domains.scss
@@ -0,0 +1,27 @@
+.foo {
+  background-image: url('https://foo.com/img/bar.png');
+}
+
+.foo {
+  background-image: url('http://foo.com/img/bar.png');
+}
+
+.foo {
+  background-image: url('//foo.com/img/bar.png');
+}
+
+.foo {
+  background-image: url('/img/bar.png');
+}
+
+.foo {
+  background-image: url('img/bar.png');
+}
+
+.foo {
+  background-image: url('bar.png');
+}
+
+.foo {
+  background-image: url('data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7');
+}