Unify components for account name and address #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andywer
reviewed
Nov 2, 2020
src/Generic/components/Address.tsx
Outdated
| @@ -94,7 +96,7 @@ interface AddressProps { | |||
| } | |||
|
|
|||
| // tslint:disable-next-line no-shadowed-variable | |||
| export const Address = React.memo(function Address(props: AddressProps) { | |||
| const BasicAddress = React.memo(function BasicAddress(props: BasicAddressProps) { | |||
There was a problem hiding this comment.
The name BasicAddress isn't great as it raises more questions than it answers. Tricky to find a better one, but how about AddressContent?
There was a problem hiding this comment.
I agree that the name is bad. AddressContent sounds reasonable 👍
andywer
reviewed
Nov 2, 2020
| } else { | ||
| return ( | ||
| <> | ||
| <PublicKey publicKey={props.publicKeys[0]} testnet={props.testnet} variant="short" />{" "} | ||
| <Address address={props.publicKeys[0]} testnet={props.testnet} />{" "} |
There was a problem hiding this comment.
Don't we still need to keep the variant="short"?
There was a problem hiding this comment.
I decided to set variant to "short" by default because we almost always use "short" anyways.
|
@ebma This PR wants to be rebased 😉 |
Unify PublicKey, Address and AccountName
ebma
force-pushed
the
feature/277-merge-accountname-and-publickey
branch
from
6d870c2 to
bf9cbb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group all components related to showing a public key or address under a new
<Address>component which conditionally renders the best component based on props.Closes #277.