Skip to content
This repository has been archived by the owner on Feb 13, 2020. It is now read-only.

use the capabilities hash in the browsers array when creating the desire... #271

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

use the capabilities hash in the browsers array when creating the desire... #271

wants to merge 2 commits into from

Conversation

QuantumGeordie
Copy link
Contributor

...d capabilities in config.

@QuantumGeordie QuantumGeordie mentioned this pull request Sep 17, 2014
Closed
@DylanLacey
Copy link
Contributor

I factored in https://github.com/saucelabs/sauce_ruby/blob/master/lib/sauce/test_base.rb#L14 to simplify some of the repetitive tasks. This bundles up the individual caps into the hash passed to each Sauce::Selenium2 object, which then gets a config effectively cloned from the global Sauce::Config object & so should have whitelisting working.

I'm going to accept this PR, then probably refactor to TestBase, unless you're keen to do that?

@QuantumGeordie
Copy link
Contributor Author

i think i see what you mean. i'l take a look later today and update this PR if i get something sorted out. thanks.

@QuantumGeordie
use test_base test_each in test_unit tests and use its parsing of per…
d5529ee 
… browser capabilities. remove the stuff from the config class added in last commit.
@QuantumGeordie
Copy link
Contributor Author

is this what you intended?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuantumGeordie @DylanLacey