Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add date filter query on observations #293

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

EspiraMarvin
Copy link
Contributor

Review Checklist

Bugs
Features
Tests

Summary*

  • fix: Bug fix for Add the items tackled here as checklists
  • feat: Completed task
  • chore: Incomplete task
    • test: Sub-task 1

Structure*

  • The Pull Request has a proper title that conforms to our MR title standards
  • The Pull Request has one commit, and if there are more than one, they should be squashed
  • The commit should have a proper title and a short description
  • The commit must be signed off
  • Unused imports are not present
  • Dead code is not present
  • Ensure dry running library to confirm changes

Tests

  • Proper and high quality unit, integration and acceptance(if applicable) tests have been written
  • The coverage threshold should not be lowered

Sign off*

  • All comments have been resolved by the reviewers
  • Approved by Czar {replace_with_czar_name}
  • Signed off by second reviewer {replace_with_name}
  • Ensure all checks are done before merging ⚠️
  • All PRs needs to be signed before merging ⚠️

N/B:

  • Add a checklist if more than one item is done.
  • Add screenshots and/or images where necessary
  • Indicate any breakages caused in the UI ❗
  • Where necessary, indicate which issue the Pull Request solves (Closes #)
  • Any new files are updated in the folder structure in the README

Copy link

github-actions bot commented Dec 7, 2023

Pull Request Test Coverage Report for Build 7129174085

  • 35 of 35 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 81.836%

Totals Coverage Status
Change from base Build 7058520689: 0.02%
Covered Lines: 5510
Relevant Lines: 6733

💛 - Coveralls

@EspiraMarvin EspiraMarvin force-pushed the add-date-filter-on-observations branch from b24ce61 to a1acff9 Compare December 8, 2023 11:45
- rebased - has observations date filter changes ONLY
@EspiraMarvin EspiraMarvin force-pushed the add-date-filter-on-observations branch from a1acff9 to bdf1de8 Compare December 8, 2023 13:18
@EspiraMarvin EspiraMarvin changed the title Add date filter on observations feat: add date filter query on observations bdf1de8 @EspiraMarvin Dec 8, 2023
@EspiraMarvin EspiraMarvin changed the title feat: add date filter query on observations bdf1de8 @EspiraMarvin feat: add date filter query on observations Dec 8, 2023
@Muchogoc Muchogoc merged commit be73e16 into develop-v2 Dec 8, 2023
6 checks passed
@Muchogoc Muchogoc deleted the add-date-filter-on-observations branch December 8, 2023 14:07
KathurimaKimathi added a commit that referenced this pull request Dec 14, 2023
* add conditions to patient timeline (#276)

* fix: fix listing of patient conditions (#278)

* fix: check encounter finished status when creating allergies (#279)

* feat: add record blood sugar api (#280)

* feat: add api to fetch a patient's blood sugar observation (#281)

* add last menstrual period vital (#283)

* add diastolic blood pressure observation (#284)

* adds fetching patient's diastolic blood pressure (#286)

* feat: token caching (#287)

* feat: add composition resource (#282)

* list patient's compositions (#289)

* query observations with encounterID filter (#290)

* query observations with encounterID filter

* updates

* query conditions with encounterID (#291)

* query compositions with encounterID (#292)

* feat: add date filter query on observations (#293)

- rebased - has observations date filter changes ONLY

* feat: add date filter on conditions (#294)

- adds date filter as a search param for conditions

---------

Co-authored-by: EspiraMarvin <[email protected]>
Co-authored-by: Salaton <[email protected]>
Co-authored-by: Charles Muchogo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants