Correct path manipulation on Windows and UNIX #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x6675636b796f75676974687562
force-pushed
the
bugfix/path-manipulation
branch
from
6a611b8 to
99fb0af
Compare
|
You marked this PR as ready, but it is not, right? I don't see any changes in existing code of sarif lib |
nulls
approved these changes
Feb 22, 2023
fixpatches/src/commonMain/kotlin/com/saveourtool/sarifutils/adapter/SarifFixAdapter.kt
Outdated
Show resolved
Hide resolved
fixpatches/src/commonMain/kotlin/com/saveourtool/sarifutils/adapter/SarifFixAdapter.kt
Show resolved
Hide resolved
fixpatches/src/commonMain/kotlin/com/saveourtool/sarifutils/adapter/SarifFixAdapter.kt
Show resolved
Hide resolved
fixpatches/src/commonMain/kotlin/com/saveourtool/sarifutils/adapter/SarifFixAdapter.kt
Show resolved
Hide resolved
fixpatches/src/commonMain/kotlin/com/saveourtool/sarifutils/net/UrilUtils.kt
Show resolved
Hide resolved
fixpatches/src/commonMain/kotlin/com/saveourtool/sarifutils/net/UrilUtils.kt
Show resolved
Hide resolved
kgevorkyan
reviewed
Feb 27, 2023
fixpatches/src/commonMain/kotlin/com/saveourtool/sarifutils/adapter/SarifFixAdapter.kt
Show resolved
Hide resolved
fixpatches/src/commonMain/kotlin/com/saveourtool/sarifutils/adapter/SarifFixAdapter.kt
Show resolved
Hide resolved
fixpatches/src/commonMain/kotlin/com/saveourtool/sarifutils/adapter/SarifFixAdapter.kt
Show resolved
Hide resolved
fixpatches/src/commonMain/kotlin/com/saveourtool/sarifutils/adapter/SarifFixAdapter.kt
Show resolved
Hide resolved
fixpatches/src/commonMain/kotlin/com/saveourtool/sarifutils/files/FileUtils.kt
Show resolved
Hide resolved
fixpatches/src/commonMain/kotlin/com/saveourtool/sarifutils/utils/SarifUtils.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to eventually address saveourtool/save-cli#489 on Windows and UNIX.
Test cases:
file://URI that contains an absolute path:file:///C:/autoexec.batfile://scheme) that contains an absolute path with forward slashes:C:/autoexec.batfile://scheme) that contains an absolute path with backslashes:C:\autoexec.batfile://URI that contains a relative path:file:autoexec.batfile://scheme) that contains a relative path:autoexec.batSupport for encoded URIs (e.g.:
file:///C%3A/Program%20Files→file:///C:/Program Files→C:\Program Files) would require much more effort and is probably out of scope for this issue.