Editing view preparations: propagating of edit flag to children components #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nents ### What's done: - Minor Spring Security Timeout update (not tested) - Propagating edit button actions to have a common editable page - Adding creation date to timeline (so it's always shown) - Adding ribbon for approved/not approved - Fix for editing short and long description - Minor fixes
orchestr7
requested review from
JustinB1eber,
sanyavertolet,
Cheshiriks and
nulls
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ktlint found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
orchestr7
force-pushed
the
feature/edit
branch
from
a989310
to
cf48d5a
Compare
sanyavertolet
approved these changes
Sep 6, 2023
...frontend/src/main/kotlin/com/saveourtool/save/frontend/components/basic/TimelineComponent.kt
Show resolved
Hide resolved
Cheshiriks
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Record.mov