Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. As mentioned in pulsar-edit#852 (comment), these are some example tests that I updated from my original work on the legacy PHP tree-sitter grammar.
The first commit runs, but most of the tests fail because it's trying to match the output of the TM grammar pretty closely. The second commit updates the tests to better match your code. eg I removed the
punctuation
scopes for semicolons, etc. Note that the second commit still has plenty of failures, because I found a few places where the new grammar maybe wasn't covering all of the bases. (eg??=
,%
andinstanceof
).The failing output I see is:
Obviously happy to make any changes you'd like to see, or just to close this if you're not interested. Thank you!