Add support for ipv6 address resolution preferences to srt.
#4317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toots
changed the title
srt.
toots
force-pushed
the
srt-ipv6only
branch
4 times, most recently
from
1b0836c to
9c7cfb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces explicit resolution settings to SRT addresses. The user can decide if addresses should be resolved as
ipv4oripv6by default.It also removes an indirection that was causing uncertainty when resolving addresses. With the chances in this PR, addresses are resolved only once and directly using the
getaddrinfoAPI.Global settings are also introduced for both SRT and icecast to allow the user to change the preference for all instances of their operators at once.