Add create method to FakeFirestore.DocumentReference #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding this! Sorry it has taken me so long to review. Would you mind fixing the most recent conflicts after the TypeScript PR? |
|
Thanks @sbatson5 for getting to this. Have tried to update from master again so it should be mergeable now |
sbatson5
approved these changes
Jan 4, 2024
|
Merged and published 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a create mock to FakeFirestore.DocumentReference as per the API https://googleapis.dev/nodejs/firestore/latest/DocumentReference.html#create
I also got npm package resolution errors which I was able to fix by upgrading prettier and the eslint-config
How to test
I've added a basic unit test to check functionality