build cleanup #249
Draft
build cleanup #249
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SethTisue
commented
Sep 7, 2024
•
SethTisue
commented
- upgrade to sbt 1.10.2 everywhere
- silence a build warning
- fix a deprecation warning
Steward missed some places when we went to 1.10.0, maybe having them all in sync now means it will get them all next time?
it seems sad to fix it by resorting to internal API, but I spent 10 minutes or so trying to find a better way and gave up. if the internal API ever goes away, we'll find out eventually
SethTisue
force-pushed
the
sbt-version-bumping
branch
from
d749681
to
4e56c0b
Compare
|
@adpi2 is there a better way than using |
adpi2
reviewed
Sep 9, 2024
Comment on lines
+20
to
+21
| import sbt.internal.util.Terminal.console | ||
| if(console.isAnsiSupported && console.isColorEnabled) Seq("GIT_PAGER_IN_USE" -> "1") |
There was a problem hiding this comment.
I don't think it is safe to use Terminal.console because it seems here that it can stay uninitialized forever.
My suggestion is:
- to continue using the deprecated
ConsoleLogger.formatEnabled - or to catch this
IllegalStateExceptionand return false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.