[1.x] Refine early return condition in invalidateAfterInternalCompilation

[Friendseeker]

Issue

In #1396, the project takes 4 cycles to compile when transitive step is set to 3, yet the project only takes 3 cycles when transitive step is above 3.

This indicates transitive invalidation interferes with cycle stopping condition. Even though everything is complied by cycle 3, when invalidateTransitively flag is set, we enter cycle 4 regardless.

Solution

In invalidateAfterInternalCompilation, we should use a non-transitive version of firstClassInvalidation to compute newInvalidations, while using a transitive version of firstClassInvalidation to compute all invalidations when invalidateTransitively flag is set.

Testing

A scripted test is added. Without the PR it takes 5 iterations. With the PR it takes 4 iterations.

[eed3si9n]

Thanks!