Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Remove compilerVersionDependentScalacOptions #1468

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Oct 18, 2024

This PR removes compilerVersionDependentScalacOptions from build.sbt as Zinc 2.x no longer needs to cross build against Scala 2.

As result a bunch more compiler deprecation warnings are surfaced in CI. For example

[warn] -- Deprecation Warning: /home/runner/work/zinc/zinc/internal/zinc-classpath/src/main/scala/sbt/internal/inc/ReflectUtilities.scala:38:29 
[warn] 38 |  def fields(clazz: Class[?]) =
[warn]    |                             ^
[warn]    |class OpenHashMap in package scala.collection.mutable is deprecated since 2.13.0: Use HashMap or one of the specialized versions (LongMap, AnyRefMap) instead of OpenHashMap

(https://github.com/sbt/zinc/actions/runs/11399506018/job/31718419535)

Is not seen in the latest develop CI run.

Closes #1467

@Friendseeker Friendseeker force-pushed the compiler-version-specfic-cleanup branch from 9a73be7 to 7ea4819 Compare October 18, 2024 07:29
@Friendseeker Friendseeker force-pushed the compiler-version-specfic-cleanup branch from 7ea4819 to 58a1ef5 Compare October 18, 2024 07:35
@Friendseeker Friendseeker marked this pull request as ready for review October 18, 2024 21:28
build.sbt Show resolved Hide resolved
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit f9ca5e7 into sbt:develop Oct 19, 2024
8 checks passed
@Friendseeker Friendseeker deleted the compiler-version-specfic-cleanup branch October 19, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants