Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ImageCapture #410

Merged
merged 7 commits into from
Sep 4, 2021
Merged

Added ImageCapture #410

merged 7 commits into from
Sep 4, 2021

Conversation

RoelofRuis
Copy link
Contributor

Does not include ImageCapture.getPhotoSettings() as its return value depends on a yet undocumented class.

Does not include ImageCapture.getPhotoCapabilities(), might be added later.

@armanbilge armanbilge changed the base branch from master to series/1.x August 10, 2021 01:47
@japgolly japgolly marked this pull request as draft August 12, 2021 23:54
@japgolly japgolly added this to the v1.2.0 milestone Aug 13, 2021
@japgolly
Copy link
Contributor

This isn't supported in Firefox or Safari.
https://developer.mozilla.org/en-US/docs/Web/API/MediaStream_Image_Capture_API#imagecapture

Let's postpone this to 2.0 and see how we're gonna handle non-standard stuff.

@japgolly japgolly modified the milestones: v1.2.0, v2.0.0 Aug 20, 2021
@japgolly
Copy link
Contributor

japgolly commented Sep 4, 2021

This isn't supported in Firefox or Safari.

So IIRC I think we said we're not gonna bother distinguishing between full and partial browser support, and that the onus would be on the user to know the (dynamic) status of the API they're calling. @armanbilge can you confirm? That was the plan right?

@armanbilge
Copy link
Member

Yep! Decided in #514 (comment). So, we can bring this back to life!

@armanbilge armanbilge self-assigned this Sep 4, 2021
@japgolly
Copy link
Contributor

japgolly commented Sep 4, 2021

Awesome, thanks! On it....

@armanbilge armanbilge assigned japgolly and unassigned armanbilge Sep 4, 2021
@japgolly japgolly changed the base branch from series/1.x to master September 4, 2021 22:11
@japgolly japgolly marked this pull request as ready for review September 4, 2021 22:11
@japgolly japgolly self-requested a review September 4, 2021 22:12
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't believe it!! We made it through every PR.

@japgolly japgolly merged commit 385bdfc into scala-js:master Sep 4, 2021
@japgolly
Copy link
Contributor

japgolly commented Sep 4, 2021

💥 !

@RoelofRuis RoelofRuis deleted the imageCapture branch September 5, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants