Clarify sample code #45
Conversation
| jsEnv := PhantomJSEnv().value | ||
| scalaJSLinkerConfig ~= { _.withESFeatures(_.withUseECMAScript2015(false)) } | ||
| Test / jsEnv := PhantomJSEnv().value | ||
| Test / scalaJSLinkerConfig ~= { _.withESFeatures(_.withUseECMAScript2015(false)) } |
There was a problem hiding this comment.
I'm not sure I agree with those changes. It's fairly intentional that we don't specify Test /, so that the two settings apply equally in the Compile and Test configurations. Did you have a specific issue by not putting them in Test /?
There was a problem hiding this comment.
Wrt the jsEnv, no issue; just limiting it's scope. The scalaJSLinkerConfig OTOH is critical that I scope by Test because I don't the real/main/non-test output coming out in ES3. I want to keep the main artifacts on ES6 and only limit the test JS to ES3 for PhantomJS. I could be wrong but I think the 99% case is going to be running tests cos it's 1 or 2 orders of magnitude faster than Node.
There was a problem hiding this comment.
Hum, I see. In that case I would still prefer that we keep the general form first, but we can a paragraph afterwards starting with something like "If you want the changes above to only apply in the Test configuration, you can scope the settings with Test / as follows:"
Test /as it's going to be the 90%+ case