Add notes for 2.0.0 cleanups

scalalandio · Jan 5, 2025 · 7137b36 · 7137b36
1 parent efd61db
commit 7137b36
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/...ons/src/main/scala/io/scalaland/chimney/internal/compiletime/datatypes/ProductTypes.scala b/...ons/src/main/scala/io/scalaland/chimney/internal/compiletime/datatypes/ProductTypes.scala
@@ -32,6 +32,7 @@ trait ProductTypes { this: Definitions =>
       sealed trait SourceType extends scala.Product with Serializable
       object SourceType {
 
+        // FIXME (2.0.0 cleanup): split into ConstructorArgVar and ConstructorBodyVal
         /** `val`/`lazy val` initialized by constructor - either as val parameter or in body */
         case object ConstructorVal extends SourceType
 

diff --git a/...ternal/compiletime/derivation/transformer/rules/TransformProductToProductRuleModule.scala b/...ternal/compiletime/derivation/transformer/rules/TransformProductToProductRuleModule.scala
@@ -67,6 +67,7 @@ private[compiletime] trait TransformProductToProductRuleModule { this: Derivatio
     )(implicit ctx: TransformationContext[From, To]): DerivationResult[Rule.ExpansionResult[ToOrPartialTo]] = {
       import ctx.config.*
 
+      // FIXME (2.0.0 cleanup): use only ConstructorArgVals as source in position-based matching, unless enabled by flag
       val usePositionBasedMatching = Type[From].isTuple || Type[To].isTuple
       lazy val fromEnabledExtractorsForPositionBasedMatching = fromExtractors.filter { case (name, getter) =>
         val fieldFlags = flags.at(TargetPath(Path(_.select(name))))