Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuntimeDataStore is no longer hardcoded in macros internals #552

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

MateuszKubuszok
Copy link
Member

now it's an implementation detail in DSL/Gateway/config parsing

…s an implementation detail in DSL/Gateway/config parsing
@MateuszKubuszok MateuszKubuszok linked an issue Jun 7, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.75%. Comparing base (e00692d) to head (f5fed6f).
Report is 114 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   87.71%   87.75%   +0.03%     
==========================================
  Files         137      137              
  Lines        5471     5455      -16     
  Branches      451      455       +4     
==========================================
- Hits         4799     4787      -12     
+ Misses        672      668       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateuszKubuszok MateuszKubuszok merged commit e0d3a52 into master Jun 7, 2024
24 checks passed
@MateuszKubuszok MateuszKubuszok deleted the dont-use-runtime-data-store-in-rules branch June 7, 2024 09:58
@MateuszKubuszok MateuszKubuszok changed the title RuntimeDataStore is no longer hanrdocded in macros internals RuntimeDataStore is no longer hardcoded in macros internals Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor internals to NOT rely on RuntimeDataStore
1 participant