fix: Highlight for named arguments in Scala 2

Previously, we were incorrectly highlighting all named arguments for case class
scalameta · Jun 19, 2023 · d97fd1f · d97fd1f
1 parent def5892
commit d97fd1f
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/mtags/src/main/scala-2/scala/meta/internal/pc/PcCollector.scala b/mtags/src/main/scala-2/scala/meta/internal/pc/PcCollector.scala
@@ -149,6 +149,7 @@ abstract class PcCollector[T](
                   .filter(_.isConstructor)
                   .flatMap(_.paramss)
                   .flatten
+                  .filter(_.name == id.name)
                   .toSet
                 (
                   (constructorParams ++ Set(

diff --git a/tests/cross/src/test/scala/tests/highlight/DocumentHighlightSuite.scala b/tests/cross/src/test/scala/tests/highlight/DocumentHighlightSuite.scala
@@ -51,6 +51,34 @@ class DocumentHighlightSuite extends BaseDocumentHighlightSuite {
       |}""".stripMargin,
   )
 
+  check(
+    "named-arg",
+    """
+      |case class Foo(foo: Int, <<bar>>: Int)
+      |object Main {
+      |  val x = Foo(
+      |    foo = 123,
+      |    <<ba@@r>> = 456
+      |  ) 
+      |
+      |}""".stripMargin,
+  )
+
+  check(
+    "named-arg1",
+    """
+      |case class Foo(<<foo>>: Int, bar: Int)
+      |object Main {
+      |  val x = Foo(
+      |    <<fo@@o>> = 123,
+      |    bar = 456
+      |  )
+      |  val y = x.<<foo>>
+      |  
+      |
+      |}""".stripMargin,
+  )
+
   check(
     "scopes",
     """