improvement: Dependency version completions for scala native #5373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkciesluk
changed the title
jkciesluk
force-pushed
the
cli-comp-double-colon
branch
from
a6e9cbe
to
da3922e
Compare
tgodzik
requested changes
Jun 28, 2023
tests/cross/src/test/scala/tests/pc/CompletionScalaCliSuite.scala
Outdated
Show resolved
Hide resolved
mtags/src/main/scala-2/scala/meta/internal/pc/completions/MillIvyCompletions.scala
Show resolved
Hide resolved
mtags-shared/src/main/scala/scala/meta/internal/mtags/CoursierComplete.scala
Show resolved
Hide resolved
mtags-shared/src/main/scala/scala/meta/internal/mtags/CoursierComplete.scala
Show resolved
Hide resolved
jkciesluk
force-pushed
the
cli-comp-double-colon
branch
from
da3922e
to
5df3d68
Compare
…a js Scala CLI and mill support syntax <org>::<name>::<version> for scala native and scala js dependencies. For Scala CLI we can default to it
jkciesluk
force-pushed
the
cli-comp-double-colon
branch
from
5df3d68
to
e30d206
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scala CLI and mill support syntax :::: for scala native and scala js dependencies. We can default to it in Scala CLI and maybe in mill too?
Also fixes version sorting for
cats-core, since there was a version1.0.0-MF, which was causing an exception