Use public API for java hover #5375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2023
ckipp01
added a commit
to ckipp01/nvim-metals
that referenced
this pull request
Jul 18, 2023
This is no longer needed as of scalameta/metals#5375. You can see more context for this in scalameta/metals#5453 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the java hover to only use the public
jdk.compilerAPI. So no--add-exportsare needed. At least I think that's trueJust seeing if this is possible really rather than moving to jdk 11 or 17.
Ideally the SCIP plugin would also only use the public API so no
--add-exportswould be needed for that but no idea on feasibility.