bugfix: Make mtags-shared published with full scala version #5380
Conversation
This seems to have caused the issues in scalameta#5293 by bringing in snapshot version of the scala 3 library Also, added a forceVersion parameters to avoid cases like this in the future.
|
Sorry, I'm not exactly understanding why using |
Sorry, I wanted to write a bit more, but got distracted. mtagsShared library was being released with _3 suffix since that's what it means when we use So the metals was bringing in scala 3 library, which cannot be used from non RC versions and that broke everything when we had Scala 3 libraries on the classpath. You can see the problem here https://mvnrepository.com/artifact/org.scalameta/mtags-shared_3/0.11.12 |
mtags3 is a workaround to make scala 3 support work without selecting version in cross-version to Scala 3
| @@ -355,6 +355,8 @@ lazy val mtags3 = project | |||
| sharedSettings, | |||
| mtagsSettings, | |||
| Compile / unmanagedSourceDirectories += (ThisBuild / baseDirectory).value / "mtags" / "src" / "main" / "scala", | |||
| Compile / unmanagedSourceDirectories += (ThisBuild / baseDirectory).value / "mtags-shared" / "src" / "main" / "scala", | |||
There was a problem hiding this comment.
I needed to change this, since we had issues compiling mtagsShared with full version and using it from mtags3. This is just a workaround to support Scala 3 better inside Metals, so this is totally fine.
This seems to have caused the issues in #5293 by bringing in snapshot version of the scala 3 library
Fixes #5293