Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: restart sbt after java home change #5381

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

kasiaMarek
Copy link
Contributor

@kasiaMarek kasiaMarek commented Jun 27, 2023

If java_home in bsp/sbt.json config is outdated restart sbt server on connect.

resolves: #5313

@kasiaMarek
Copy link
Contributor Author

@tgodzik should I ask the user if they want to restart the sbt server?

@tgodzik
Copy link
Contributor

tgodzik commented Jul 11, 2023

@tgodzik should I ask the user if they want to restart the sbt server?

I think that's what we do with bloop so yeah.

@kasiaMarek kasiaMarek marked this pull request as ready for review July 11, 2023 10:56
@kasiaMarek kasiaMarek changed the title improvement: restart sbt when after java home change improvement: restart sbt after java home change Jul 12, 2023
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One super minor comment, but otherwise LGTM!

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kasiaMarek kasiaMarek merged commit 6f47009 into scalameta:main Jul 20, 2023
22 of 23 checks passed
@jkciesluk jkciesluk modified the milestone: Metals v1.0.1 Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect error messages breaking project, looping build
3 participants