Check parent docs even when class is indexed #5382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiaMarek
reviewed
Jun 28, 2023
mtags/src/main/scala/scala/meta/internal/metals/Docstrings.scala
Outdated
Show resolved
Hide resolved
kasiaMarek
reviewed
Jun 28, 2023
mtags/src/main/scala/scala/meta/internal/metals/Docstrings.scala
Outdated
Show resolved
Hide resolved
Arthurm1
force-pushed
the
parent_docs_fix
branch
from
0d9f98c
to
278f17b
Compare
|
@kasiaMarek I've rewritten the method to make the flow clearer and use of |
kasiaMarek
approved these changes
Jun 28, 2023
|
@kasiaMarek I don't think I have merge permissions anymore. Can you merge please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5374. I hope - can't run the tests locally as they're flakey on Windows