fix: obey hover markup kind capability
#6303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
reviewed
Apr 17, 2024
metals/src/main/scala/scala/meta/internal/metals/MetalsSymbolSearch.scala
Show resolved
Hide resolved
tgodzik
requested changes
Apr 17, 2024
metals/src/main/scala/scala/meta/internal/metals/InlayHintResolveProvider.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/MetalsSymbolSearch.scala
Show resolved
Hide resolved
| * Returns the type of the expression at the given position along with the | ||
| * symbol of the referenced symbol. | ||
| */ | ||
| public CompletableFuture<Optional<HoverSignature>> hover(OffsetParams params, ContentType contentType) { |
There was a problem hiding this comment.
could we instead of adding a new method add it to PresentationCompilerConfig ?
| @@ -29,22 +30,23 @@ import scala.meta.pc.SymbolDocumentation | |||
| * Handles both javadoc and scaladoc. | |||
| */ | |||
| class Docstrings(index: GlobalSymbolIndex) { | |||
| val cache = new TrieMap[String, SymbolDocumentation]() | |||
| val cache = new TrieMap[(String, ContentType), SymbolDocumentation]() | |||
There was a problem hiding this comment.
Suggested change
| val cache = new TrieMap[(String, ContentType), SymbolDocumentation]() | |
| val cache = new TrieMap[Content, SymbolDocumentation]() |
Maybe create a case class for it? Or:
sealed trait Content extends Any
class Markdown(val text: String) extends AnyVal with Content
class Plain(val text: String) extends AnyVal with Content| def toPlaintext(b: Body): String = | ||
| Option(b).map(body => printBlocks(body.blocks)).mkString("\n") | ||
|
|
||
| def toPlaintext(c: Comment, docstring: String): String = { |
There was a problem hiding this comment.
Any chance to share some of MarkdownGenerator implementation?
tgodzik
approved these changes
Apr 19, 2024
| class Plain(val text: String) extends AnyVal with Content | ||
|
|
||
| object Content { | ||
| def from(text: String, contentType: ContentType): AnyVal with Content = |
There was a problem hiding this comment.
Suggested change
| def from(text: String, contentType: ContentType): AnyVal with Content = | |
| def from(text: String, contentType: ContentType): Content = |
would be enough
tgodzik
added a commit
to tgodzik/dotty
that referenced
this pull request
May 6, 2024
tgodzik
added a commit
to tgodzik/dotty
that referenced
this pull request
May 6, 2024
rochala
pushed a commit
to scala/scala3
that referenced
this pull request
May 6, 2024
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jul 6, 2024
Changes from: - scalameta/metals#6225 - scalameta/metals#6236 - scalameta/metals#6241 - scalameta/metals#6303 - scalameta/metals#6308 [Cherry-picked 1cdf99f]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jul 6, 2024
Changes from: - scalameta/metals#6225 - scalameta/metals#6236 - scalameta/metals#6241 - scalameta/metals#6303 - scalameta/metals#6308 [Cherry-picked 1cdf99f]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #6293