Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cover additional cases for singleton types #6541

Merged
merged 2 commits into from
Jun 27, 2024
Merged

fix: cover additional cases for singleton types #6541

merged 2 commits into from
Jun 27, 2024

Conversation

kasiaMarek
Copy link
Contributor

@kasiaMarek kasiaMarek marked this pull request as ready for review June 26, 2024 11:28
@nguyenyou
Copy link

Thank you very much for working on this @kasiaMarek 💯

@kasiaMarek kasiaMarek requested a review from tgodzik June 26, 2024 12:18
tgodzik
tgodzik approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kasiaMarek kasiaMarek merged commit 8bebd63 into scalameta:main Jun 27, 2024
23 of 25 checks passed
@kasiaMarek kasiaMarek mentioned this pull request Jul 15, 2024
Merged
tgodzik added a commit to scala/scala3 that referenced this pull request Jul 25, 2024
@tgodzik
Backport from metals (#21196)
dec395b 
contains:
scalameta/metals#6583

scalameta/metals#6575

scalameta/metals#6551

scalameta/metals#6498
scalameta/metals#6541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@nguyenyou nguyenyou nguyenyou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kasiaMarek @nguyenyou @tgodzik