Basic support for new .mill source files
#6752
Open
+23
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mill is migrating from the `.sc` suffix to `.mill` to distinguish its files from ammonite and scala-cli script files. `.sc` will be still supported in a migration period
tgodzik
requested changes
Sep 4, 2024
| @@ -17,6 +17,16 @@ class CompletionMillIvySuite extends BaseCompletionSuite { | |||
| filename = "build.sc" | |||
| ) | |||
|
|
|||
| check( | |||
| "source", | |||
| """|val dependency = ivy"io.cir@@" | |||
There was a problem hiding this comment.
I think we have a lot of places where we check if something is a scala file:
|
We might also need to update the Scala syntax extension and Metals vs code extension |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mill is migrating from the
.scsuffix to.millto distinguish its files from ammonite and scala-cli script files..scwill be still supported in a migration periodPR which introduced the new suffix: com-lihaoyi/mill#3426