Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't pass --best-effort flag for bazel #6786

Merged
merged 3 commits into from
Sep 20, 2024
Merged

fix: Don't pass --best-effort flag for bazel #6786

merged 3 commits into from
Sep 20, 2024

Conversation

anupc-db
Copy link
Contributor

--best-effort is not a valid bazel build flag

@anupc-db
fix: Don't pass --best-effort flag for bazel
ec3a550 
`--best-effort` is not a valid `bazel build` flag
tgodzik
tgodzik requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! I have just a minor suggestion. Probably can be done much nicer than the suggestion in github.

metals/src/main/scala/scala/meta/internal/metals/Compilations.scala Outdated Show resolved Hide resolved
tgodzik
tgodzik approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgodzik tgodzik merged commit 75046bd into scalameta:main Sep 20, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anupc-db @tgodzik