Make auto-pr robust to avoid timing issue or etc #1347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently observed a few times that Auto-PR workflow wasn't triggered. I asked GitHub support and they recommended the following options:
Use pull_request_target event instead of pull_request event
Remove the current guard condition
types: closed
to mitigate the risk of failing to trigger the workflowFor 1,
pull_request_target
is more powerful. But it also introduces some security concerns. So, trying 2 would be reasonable.Related issues and/or PRs
N/A
Changes made
This PR removes the guard condition
types: closed
to mitigate the risk of failing to invoke the workflow. It should be okay since the workflow also hasif_merged: if: github.event.pull_request.merged == true
condition.Checklist
Additional notes (optional)
N/A
Release notes
N/A