Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR #1411 #1416

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Revert PR #1411 #1416

merged 1 commit into from
Dec 26, 2023

Conversation

kota2and3kan
Copy link
Contributor

Description

This PR reverts to PR #1411. Sorry, I had a misunderstanding about the current workflow's structures... πŸ™‡β€β™€οΈ

The workflow upload-artifacts.yaml is called from the parent workflow release.yaml. And the parent workflow release.yaml has the configuration of permissions.

So, the upload-artifacts.yaml can run with the same permissions settings that are inherited from release.yaml. Therefore, we don't need to set permissions on the upload-artifacts.yaml side explicitly.

FYI: The action ran properly when we released v3.10.2 yesterday, without the fixes of #1411. Also from this log, we can see that we don't need the fix of #1411.
https://github.com/scalar-labs/scalardb/actions/runs/7322292094

Related issues and/or PRs

#1411

Changes made

  • Update (revert) upload-artifacts.yaml file.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 merged commit 29c3574 into master Dec 26, 2023
23 checks passed
@brfrn169 brfrn169 deleted the revert-pr-1411 branch December 26, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants