Should perform lazy recovery in implicit pre-read #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komamitsu
approved these changes
Jan 31, 2024
| @@ -135,6 +134,9 @@ public void commit() throws CommitException, UnknownTransactionStatusException { | |||
| try { | |||
| crud.readIfImplicitPreReadEnabled(); | |||
| } catch (CrudConflictException e) { | |||
| if (e instanceof UncommittedRecordException) { | |||
There was a problem hiding this comment.
[minor] Or, explicitly catching UncommittedRecordException is also an option?
// Execute implicit pre-read
try {
crud.readIfImplicitPreReadEnabled();
} catch (UncommittedRecordException e) {
lazyRecovery(e);
throw new CommitConflictException("Read uncommitted record while implicit pre-read", e, getId());
} catch (CrudConflictException e) {
throw new CommitConflictException("Conflict occurred while implicit pre-read", e, getId());
} catch (CrudException e) {
throw new CommitException("Failed to execute implicit pre-read", e, getId());
}There was a problem hiding this comment.
Yeah, that's an option. I didn't do that because I didn't think we needed to change the error message base on the cause, as we pass the cause exception to CommitConflictException.
throw new CommitConflictException("Conflict occurred while implicit pre-read", e /* the cause exception */, getId());What do you think?
| @@ -137,6 +136,9 @@ public void prepare() throws PreparationException { | |||
| try { | |||
| crud.readIfImplicitPreReadEnabled(); | |||
| } catch (CrudConflictException e) { | |||
| if (e instanceof UncommittedRecordException) { | |||
jnmt
approved these changes
Jan 31, 2024
feeblefakie
reviewed
Jan 31, 2024
| } | ||
|
|
||
| @SuppressFBWarnings("EI_EXPOSE_REP2") | ||
| public UncommittedRecordException( |
There was a problem hiding this comment.
This seems not used. Do you want to keep it for future use?
There was a problem hiding this comment.
I left this here because it was originally here. But yes, we don't need to leave it. I'll remove it. Thanks.
There was a problem hiding this comment.
Fixed in 5c4d6a7. Thanks.
feeblefakie
deleted the
should-perform-lazy-recovery-in-implicit-pre-read
branch
feeblefakie
pushed a commit
that referenced
this pull request
Jan 31, 2024
feeblefakie
pushed a commit
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when uncommitted records are read while executing implicit pre-read, lazy recovery is not performed, which is unexpected behavior. This PR addresses issue.
Related issues and/or PRs
Changes made
Checklist
Additional notes (optional)
N/A
Release notes
Fixed a bug where lazy recovery is not performed when uncommitted records are read while executing implicit pre-read.