Use operation attributes for implicit pre-read and insert mode of Put #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brfrn169
commented
Nov 18, 2024
Comment on lines
-45
to
-47
| private boolean implicitPreReadEnabled; | ||
|
|
||
| private boolean insertModeEnabled; |
There was a problem hiding this comment.
Removed the flags for implicit pre-read and insert mode. Instead, use the operation attributes for them.
| import java.util.Optional; | ||
|
|
||
| /** A class to manage the operations attributes for Consensus Commit. */ | ||
| public final class ConsensusCommitOperationAttribute { |
There was a problem hiding this comment.
Added ConsensusCommitOperationAttribute to manage the operations attributes for Consensus Commit.
komamitsu
approved these changes
Nov 19, 2024
| Put setImplicitPreReadEnabled(boolean implicitPreReadEnabled) { | ||
| this.implicitPreReadEnabled = implicitPreReadEnabled; | ||
| return this; | ||
| return ConsensusCommitOperationAttribute.isImplicitPreReadEnabled(this); |
There was a problem hiding this comment.
Just an idea: Moving these operations to ConsensusCommitOperationAttribute's instance methods and replacing ImmutableMap<String, String> attributes with ConsensusCommitOperationAttribute attributes might be an option in the future.
…read-and-insert-mode-of-put
feeblefakie
deleted the
use-operation-attributes-for-implicit-pre-read-and-insert-mode-of-put
branch
feeblefakie
pushed a commit
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the code to use operation attributes (introduced in #2333) for implicit pre-read and insert mode of Put.
Related issues and/or PRs
Changes made
ConsensusCommitOperationAttributeto manage the operations attributes for Consensus Commit.Checklist
Additional notes (optional)
N/A
Release notes
N/A