Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefix to error code #2444

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Add prefix to error code #2444

merged 1 commit into from
Jan 6, 2025

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Dec 26, 2024 •
edited
Loading

Description

This PR adds the prefix (DB-) to the error code.

Related issues and/or PRs

N/A

Changes made

  • Added the prefix (DB-) to the error code.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@brfrn169 brfrn169 self-assigned this Dec 26, 2024
feeblefakie
feeblefakie approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Torch3333
Torch3333 approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

josh-wong
josh-wong approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@josh-wong josh-wong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!🙇🏻‍♂️

komamitsu
komamitsu approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@brfrn169 brfrn169 merged commit 8155eba into master Jan 6, 2025
48 checks passed
@brfrn169 brfrn169 deleted the add-prefix-to-error-code branch January 6, 2025 02:38
feeblefakie pushed a commit that referenced this pull request Jan 6, 2025
@brfrn169
Add prefix to error code (#2444)
e7a2de7
@feeblefakie feeblefakie mentioned this pull request Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-wong josh-wong josh-wong approved these changes

@Torch3333 Torch3333 Torch3333 approved these changes

@feeblefakie feeblefakie feeblefakie approved these changes

@komamitsu komamitsu komamitsu approved these changes

Assignees

@brfrn169 brfrn169

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brfrn169 @komamitsu @feeblefakie @Torch3333 @josh-wong