Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing unit tests for MariaDB RdbEngine #2465

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix missing unit tests for MariaDB RdbEngine #2465

merged 1 commit into from
Jan 20, 2025

Conversation

Torch3333
Copy link
Contributor

@Torch3333 Torch3333 commented Jan 17, 2025 •
edited
Loading

Description

When adding the MariaDB driver in #2391, I forgot to modify some unit test related to the RdbEngineMariaDB class.

Related issues and/or PRs

Changes made

Add missing unit test change to test the RdbEngineMariaDB class fully.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@Torch3333 Torch3333 self-assigned this Jan 17, 2025
@Torch3333 Torch3333 marked this pull request as ready for review January 17, 2025 02:11
komamitsu
komamitsu approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

brfrn169
brfrn169 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

feeblefakie
feeblefakie approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 8c96c1a into master Jan 20, 2025
48 checks passed
@feeblefakie feeblefakie deleted the fix_missing_unit_test_for_mariadb_rdb_engine branch January 20, 2025 04:41
@feeblefakie feeblefakie mentioned this pull request Jan 20, 2025
Merged
Torch3333 added a commit that referenced this pull request Jan 20, 2025
@Torch3333
Fix missing unit tests for MariaDB RdbEngine (#2465)
bdc7f30 
# Conflicts:
#	core/src/test/java/com/scalar/db/storage/jdbc/JdbcAdminTestBase.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feeblefakie feeblefakie feeblefakie approved these changes

@brfrn169 brfrn169 brfrn169 approved these changes

@komamitsu komamitsu komamitsu approved these changes

Assignees

@Torch3333 Torch3333

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Torch3333 @komamitsu @brfrn169 @feeblefakie