Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused table added by mistake from integration test #2478

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Remove unused table added by mistake from integration test #2478

merged 1 commit into from
Jan 23, 2025

Conversation

Torch3333
Copy link
Contributor

@Torch3333 Torch3333 commented Jan 23, 2025 •
edited
Loading

Description

This removes a table added by mistake in #2474 for debugging purposes.

Related issues and/or PRs

Changes made

Remove an unused table from DistributedTransactionAdminIntegrationTestBase

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@Torch3333 Torch3333 self-assigned this Jan 23, 2025
@Torch3333 Torch3333 removed the bugfix label Jan 23, 2025
@Torch3333 Torch3333 marked this pull request as ready for review January 23, 2025 08:27
@Torch3333 Torch3333 changed the title Remove unused table Remove unused table from integration test Jan 23, 2025
@Torch3333 Torch3333 changed the title Remove unused table from integration test Remove unused table added by mistake from integration test Jan 23, 2025
@Torch3333 Torch3333 requested a review from brfrn169 January 23, 2025 08:28
@brfrn169 brfrn169 merged commit 51805e7 into 3 Jan 23, 2025
48 checks passed
@brfrn169 brfrn169 deleted the remove_unused_table branch January 23, 2025 09:15
brfrn169
brfrn169 reviewed Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brfrn169 brfrn169 brfrn169 left review comments

Assignees

@Torch3333 Torch3333

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Torch3333 @brfrn169