Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to branch(3.13) : Add table metadata service #2504

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Conversation

feeblefakie
Copy link
Contributor

This is an automated request for a manual backport of the following:

  1. Resolve any conflicts that occur during the cherry-picking process.
git fetch origin &&
git checkout 3.13-pull-2434 &&
git cherry-pick --no-rerere-autoupdate -m1 85ca0eb166380f76eb514b9275aade21a44d6753
  1. Push the changes.
  2. Merge this PR after all checks have passed.

Thank you!

Comment on lines 703 to 744
OUT_OF_RANGE_COLUMN_VALUE_FOR_DATE(
Category.USER_ERROR,
"0158",
"This DATE column value is out of the valid range. It must be between 1000-01-01 and 9999-12-12. Value: %s",
"",
""),
SUBMICROSECOND_PRECISION_NOT_SUPPORTED_FOR_TIME(
Category.USER_ERROR,
"0159",
"This TIME column value precision cannot be shorter than one microsecond. Value: %s",
"",
""),
OUT_OF_RANGE_COLUMN_VALUE_FOR_TIMESTAMP(
Category.USER_ERROR,
"0160",
"This TIMESTAMP column value is out of the valid range. It must be between 1000-01-01T00:00:00.000 and 9999-12-31T23:59:59.999. Value: %s",
"",
""),
SUBMILLISECOND_PRECISION_NOT_SUPPORTED_FOR_TIMESTAMP(
Category.USER_ERROR,
"0161",
"This TIMESTAMP column value precision cannot be shorter than one millisecond. Value: %s",
"",
""),
OUT_OF_RANGE_COLUMN_VALUE_FOR_TIMESTAMPTZ(
Category.USER_ERROR,
"0162",
"This TIMESTAMPTZ column value is out of the valid range. It must be between 1000-01-01T00:00:00.000Z to 9999-12-31T23:59:59.999Z. Value: %s",
"",
""),
SUBMILLISECOND_PRECISION_NOT_SUPPORTED_FOR_TIMESTAMPTZ(
Category.USER_ERROR,
"0163",
"This TIMESTAMPTZ column value precision cannot be shorter than one millisecond. Value: %s",
"",
""),
JDBC_IMPORT_DATA_TYPE_OVERRIDE_NOT_SUPPORTED(
Category.USER_ERROR,
"0164",
"The underlying-storage data type %s is not supported as the ScalarDB %s data type: %s",
"",
""),
Copy link
Collaborator

@brfrn169 brfrn169 Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.13 doesn't have the time-related types. Please remove these messages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brfrn169 san,
Thank you.
I have removed the unwanted error messages.

@inv-jishnu inv-jishnu requested a review from brfrn169 February 3, 2025 05:07
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 marked this pull request as ready for review February 3, 2025 05:12
@brfrn169 brfrn169 merged commit 40c926b into 3.13 Feb 3, 2025
49 checks passed
@brfrn169 brfrn169 deleted the 3.13-pull-2434 branch February 3, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants