Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/SK-1259 | Use api/v1 for set_active_package in APIClient #775

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

Wrede
Copy link
Member

@Wrede Wrede commented Dec 16, 2024

This pull request includes changes to the fedn/network/api/client.py file to improve the set_active_package method. The most important changes include modifying default parameter values and updating the URL endpoint used in the method.

Improvements to set_active_package method:

  • Changed default values for name and description parameters from None to empty strings.
  • Updated the URL endpoint from self._get_url("set_package") to self._get_url_api_v1("packages") for setting the package.

fedn/network/api/client.py Outdated Show resolved Hide resolved
@Wrede Wrede removed the minor label Jan 23, 2025
@Wrede Wrede merged commit e475618 into master Jan 23, 2025
17 checks passed
@Wrede Wrede deleted the fix/SK-1259 branch January 23, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants