Fix/SK-1318 | Fixed critical security vulnerability #847 (zlib) #787
+28
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminastrand
requested review from
Wrede,
niklastheman and
stefanhellander
niklastheman
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the critical security vulnerability CVE-2023-45853. Code scanning alert on GitHub here.
The vulnerability arises because Debian Bookworm uses an old version (1:1.2.13.dfsg-1) of the C library zlib (used for handling zip files). This version of zlib has a vulnerability which is fixed in version 1:1.3.dfsg+really1.3.1-1+b1 (Debian Security Tracker).
Solution:
Note
Trivy doesn't pick up on this solution. It sees that Debian Bookworm is used, and assumes that the vulnerable version (1:1.2.13.dfsg-1) of zlib is installed. Therefor this vulnerability ID has been added to
.trivyignore, since we know that it has been fixed. See this discussion on Trivy's GitHub about solving this problem.