-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/SK-1254 | add .fednignore for fedn package #801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good! I would consider calling the .ignore
file something more descriptive like .packageignore
or .fednignore
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job man! Great improvement to our software! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running fedn package create -p client creates the .tar and places it inside of the client folder, not the current working directory. Is this an intended update or an unintended bug?
intended. |
Changes work for my example(s) |
This pull request includes changes to multiple client examples and the
fedn
CLI to improve the handling of ignore patterns and package creation.Client Example Updates:
.ignore
files to various client examples to exclude__pycache__
, data directories, and specific venv directories. [1] [2] [3] [4] [5] [6] [7] [8]python_env.yaml
files to change the environment names to use a dot prefix, ensuring consistency across examples. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]fedn
CLI Enhancements:create_tar_with_ignore
inpackage_cmd.py
to create tar archives while respecting ignore patterns specified in.ignore
files. This function logs the files being added and handles potential errors gracefully.create_cmd
function to use the newcreate_tar_with_ignore
function, improving the robustness of the package creation process.