-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/SK-1343 | Enable use of any S3 backend #809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be outside the scope of this pr but we could reflect about whether or not the Repository class is needed. Controller etc, could accept RepositoryBase as input which in turn then would be realized by MinioRepository or SaasRepositoty. There might be an explanation that for me is unclear, but it's an observation :)
Absolutely, I think this should be cleaned up more. Probably should get rid of miniorepository.py as well and have one S3 class, but want to keep these changes as minimal as possible for now to ensure this also works with docker compose as well as old projects in the SaaS for now. |
Sounds good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ!
Description
Enables use of any S3 backend also when deployed via Studio.