Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/SK-1343 | Enable use of any S3 backend #809

Merged
merged 23 commits into from
Feb 13, 2025
Merged

Conversation

stefanhellander
Copy link
Collaborator

Description

Enables use of any S3 backend also when deployed via Studio.

@github-actions github-actions bot added minor feature New feature or request labels Feb 7, 2025
@Wrede Wrede added the HOLD label Feb 7, 2025
Copy link
Contributor

@niklastheman niklastheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be outside the scope of this pr but we could reflect about whether or not the Repository class is needed. Controller etc, could accept RepositoryBase as input which in turn then would be realized by MinioRepository or SaasRepositoty. There might be an explanation that for me is unclear, but it's an observation :)

@stefanhellander
Copy link
Collaborator Author

Might be outside the scope of this pr but we could reflect about whether or not the Repository class is needed. Controller etc, could accept RepositoryBase as input which in turn then would be realized by MinioRepository or SaasRepositoty. There might be an explanation that for me is unclear, but it's an observation :)

Absolutely, I think this should be cleaned up more. Probably should get rid of miniorepository.py as well and have one S3 class, but want to keep these changes as minimal as possible for now to ensure this also works with docker compose as well as old projects in the SaaS for now.

@niklastheman
Copy link
Contributor

Might be outside the scope of this pr but we could reflect about whether or not the Repository class is needed. Controller etc, could accept RepositoryBase as input which in turn then would be realized by MinioRepository or SaasRepositoty. There might be an explanation that for me is unclear, but it's an observation :)

Absolutely, I think this should be cleaned up more. Probably should get rid of miniorepository.py as well and have one S3 class, but want to keep these changes as minimal as possible for now to ensure this also works with docker compose as well as old projects in the SaaS for now.

Sounds good!

Copy link
Member

@Wrede Wrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

@stefanhellander stefanhellander merged commit 88c8da9 into master Feb 13, 2025
21 checks passed
@stefanhellander stefanhellander deleted the feature/SK-1343 branch February 13, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants