BKTCLT-19 [squash] rename test var to avoid conflicts, remove unneces…

…sary Ordered test attribute
scality · Sep 25, 2024 · 6e0cc88 · 6e0cc88
1 parent cbfe74f
commit 6e0cc88
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/go/admin_getbucketsessionid_test.go b/go/admin_getbucketsessionid_test.go
@@ -7,7 +7,7 @@ import (
 	"github.com/jarcoal/httpmock"
 )
 
-var _ = Describe("AdminGetBucketSessionId()", Ordered, func() {
+var _ = Describe("AdminGetBucketSessionId()", func() {
 	It("return the raft session ID hosting a bucket", func(ctx SpecContext) {
 		httpmock.RegisterResponder(
 			"GET", "http://localhost:9000/_/buckets/my-bucket/id",

diff --git a/go/admin_getsessioninfo_test.go b/go/admin_getsessioninfo_test.go
@@ -9,7 +9,7 @@ import (
 	"github.com/scality/bucketclient/go"
 )
 
-var bucketdResponse = `[
+var testAdminGetAllSessionsInfoBucketdResponse = `[
   {
     "id": 1,
     "raftMembers": [
@@ -43,12 +43,12 @@ var bucketdResponse = `[
 ]
 `
 
-var _ = Describe("AdminGetSessionInfo()/AdminGetAllSessionsInfo()", Ordered, func() {
+var _ = Describe("AdminGetSessionInfo()/AdminGetAllSessionsInfo()", func() {
 	Describe("AdminGetAllSessionsInfo()", func() {
 		It("return info about all raft sessions", func(ctx SpecContext) {
 			httpmock.RegisterResponder(
 				"GET", "http://localhost:9000/_/raft_sessions",
-				httpmock.NewStringResponder(200, bucketdResponse),
+				httpmock.NewStringResponder(200, testAdminGetAllSessionsInfoBucketdResponse),
 			)
 			Expect(client.AdminGetAllSessionsInfo(ctx)).To(Equal([]bucketclient.SessionInfo{
 				{
@@ -89,7 +89,7 @@ var _ = Describe("AdminGetSessionInfo()/AdminGetAllSessionsInfo()", Ordered, fun
 		It("return info about a particular raft session", func(ctx SpecContext) {
 			httpmock.RegisterResponder(
 				"GET", "http://localhost:9000/_/raft_sessions",
-				httpmock.NewStringResponder(200, bucketdResponse),
+				httpmock.NewStringResponder(200, testAdminGetAllSessionsInfoBucketdResponse),
 			)
 			Expect(client.AdminGetSessionInfo(ctx, 2)).To(Equal(&bucketclient.SessionInfo{
 				ID: 2,
@@ -110,7 +110,7 @@ var _ = Describe("AdminGetSessionInfo()/AdminGetAllSessionsInfo()", Ordered, fun
 		It("return an error if the session doesn't exist", func(ctx SpecContext) {
 			httpmock.RegisterResponder(
 				"GET", "http://localhost:9000/_/raft_sessions",
-				httpmock.NewStringResponder(200, bucketdResponse),
+				httpmock.NewStringResponder(200, testAdminGetAllSessionsInfoBucketdResponse),
 			)
 			_, err := client.AdminGetSessionInfo(ctx, 3)
 			bcErr, ok := err.(*bucketclient.BucketClientError)