Buffer backend rework, SSBO support #523
Conversation
…ayout the planed implementation
skalarproduktraum
added
enhancement
src/main/kotlin/graphics/scenery/backends/vulkan/VulkanObjectState.kt
Outdated
Show resolved
Hide resolved
| @@ -709,6 +711,17 @@ open class VulkanRenderer(hub: Hub, | |||
| usage = VK_BUFFER_USAGE_VERTEX_BUFFER_BIT or VK_BUFFER_USAGE_INDEX_BUFFER_BIT or VK_BUFFER_USAGE_TRANSFER_DST_BIT | |||
| ) | |||
|
|
|||
| ssboUploadPool = VulkanBufferPool( | |||
| device, | |||
| usage = VK_BUFFER_USAGE_STORAGE_BUFFER_BIT or VK_BUFFER_USAGE_TRANSFER_DST_BIT | |||
There was a problem hiding this comment.
Just to double-check: the upload pool is intended to receive data from the CPU side, yes? Then TRANSFER_DST_BIT is correct. Otherwise the two need to be switched. Also, is there a particular reason to have two pools? There's likely no performance issue with having one that has both SRC and DST.
There was a problem hiding this comment.
On the GPU side, there is a slight performance boost, as SSBOs are layed out differently. Also, a read only buffer can live in faster device local memory, while a writable buffer needs to be host visible or coherent (not to familiar with the concepts yet)
Thats why I decided to split up and download buffers into 2. You dont always want to write into a buffer and vice verse. Especially for read only buffers it might be good to keep this practice
| @@ -0,0 +1,184 @@ | |||
| package graphics.scenery.primitives | |||
There was a problem hiding this comment.
This is the completely wrong place for an example 😅 And if it's not an actual test (which seems to be the case) then it should not be named Test (this might actually lead to issues with auto-discovery of tests, some of my logic there just filters by class name)
There was a problem hiding this comment.
Ahh yes, at that point I wasn't sure what to do to test it. Its more a help for me to visualize the general data flow through the renderer ':D
… filled initializeNode for Node.ifBuffers()
… buffer description contains buffer
…ics/scenery into BufferBackendRework
…dating, TODO: fix Attachment 1 not wrtitten to in frag-shader
…ibutes, currentProblem: no suitable pipeline is created for the demanding shaderModule
…hader instead of the class
… of buffers which are then inserted into the bindings. Buffer allocation is bugged
…Also implemented crude descriptor logic and parent-child chaining for Compute-Other chains
…to Buffers.kt and pipeline through VRenderer backend. Open: Fix buffer copying -> data is missing at the end
No description provided.