Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: atmosphere shader #594

Merged
merged 34 commits into from
Feb 19, 2024
Merged

Conversation

smlpt
Copy link
Contributor

@smlpt smlpt commented Aug 16, 2023

Implements a dynamic atmosphere shader, based on the Nishita sky model. The code is ported from https://github.com/wwwtyro/glsl-atmosphere.
An example can be found in basic/AtmosphereExample.

  • (dynamically hand over sun position data via @ShaderProperty)
  • Implement key binds for sun position (via dragsphere behavior)
  • write vertex shader for sunproxy sphere to disable translational movement circumvented dragbehavior with keybinds
  • Synchronize a directional light to the sun position
  • Create a default atmosphere object that can be imported to automatically set up an atmosphere
  • Add an emission material property to the render pipeline so that the atmosphere object does not require to be lit by point lights
  • Create vertex shader to to always put the icosphere in the background like a skybox (see learnopengl.com)
  • local time to sun position
  • update sun position with coroutine
  • clean up code

@smlpt smlpt self-assigned this Aug 16, 2023
@smlpt smlpt added enhancement Issue or PR discusses an enhancement vulkan Concerns only the Vulkan backend labels Aug 16, 2023
@smlpt smlpt marked this pull request as ready for review October 4, 2023 12:28
smlpt added 24 commits November 6, 2023 10:08
@smlpt smlpt force-pushed the feature/atmosphere-shader branch from 7140f67 to e24d198 Compare November 6, 2023 09:11
@moreApi moreApi removed their request for review November 8, 2023 17:19
Copy link
Member

@skalarproduktraum skalarproduktraum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, only some minor stuff left 👍

Copy link
Member

@skalarproduktraum skalarproduktraum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @smlpt 👍

@skalarproduktraum skalarproduktraum merged commit 46d861c into main Feb 19, 2024
6 checks passed
@skalarproduktraum skalarproduktraum deleted the feature/atmosphere-shader branch February 19, 2024 10:57
@smlpt smlpt restored the feature/atmosphere-shader branch March 11, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue or PR discusses an enhancement vulkan Concerns only the Vulkan backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants