Cam rotation and stats #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skalarproduktraum
requested changes
Nov 6, 2023
| * with [fromPathRawSplit] to load volume files greater than 2 GiB into sliced partitions and place | ||
| * the partitions back-to-back, emulating a single large volume in the scene. | ||
| */ | ||
| fun positionSlices(volumes: List<Volume>, pixelToWorld: Float) { |
There was a problem hiding this comment.
I am not a fan of having this as a static method. How about an extension function of Volume or RichNode, so you can call this directly on the parent node? Also, pixelToWorld should get the default value volumes.first().pixelToWorldRatio, so you don't always have to hand it over.
There was a problem hiding this comment.
Sure, moved the positionSlices function to RichNode where it is called positionVolumeSlices and does not take pixelToWorld as parameter
skalarproduktraum
approved these changes
Jan 19, 2024
skalarproduktraum
approved these changes
Jan 19, 2024
…ation by fixed yaw/pitch, refactors 'drag' function
…s' function of ArcballCameraControl
…ballCameraControl
… positioning split volumes resp.
…d positionSlices functions of Volume
…rom Volume to positionVolumeSlices in RichNode
…or fromPathRaw from UnsignedByteType() to UnsignedShortType()
skalarproduktraum
force-pushed
the
cam-rotation-and-stats
branch
from
1ee15b2 to
e1bdc8d
Compare
skalarproduktraum
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds small miscellaneous functionalities: 1) use the
ArcballCamerato rotate camera about a target by a fixed angle, 2) clearing an item recorded by theStatisticsclass. ExtendsfromPathRawfunction inVolumeto transparently handle volume buffers larger than 2 GB