implemented missing methods, fixes issue #28 #29
Conversation
|
@schmittjoh Can you have a look as soon as possible as I'm waiting for this fix to release 2.1.0 beta1. Thanks. |
|
I can't verify this patch until I'm home, but apparently it does not work judging from the comments on #28. |
| 'finder' => $this->finder, | ||
| 'filePattern' => $this->filePattern, | ||
| 'files' => $this->files, | ||
| ); |
There was a problem hiding this comment.
you need to save $this->directories too
| public function serialize() | ||
| { | ||
| $resourceMap = array( | ||
| 'finder' => $this->finder, |
There was a problem hiding this comment.
do you really need to serialize the finder ? It is not necessary to rebuild the resource as it is instantiated inside the class anyway. So it could be recreated in unserialize(), making the serialized data smaller
There was a problem hiding this comment.
indeed, I'll update the PR, thank you
|
I've reverted the code from Symfony master for now as it introduces too many regression. Of course, this PR is still important as the code will be reintroduced for Symfony 2.1 beta1. |
|
@fabpot, do you think the interface will change until then? |
|
until beta1 ? no as it is released :) |
|
Hello so now when I update my project via composer I get the error : Warning: Class JMS\DiExtraBundle\Config\FastDirectoriesResource has no unserializer Do you miss something to merge this PR ? |
|
@nicolas-bastien just double check you |
|
@jonathaningram thanks I did it but as I have copied youbs change before I thought the correction came from this and not my cache ! |
These are @jonathaningram changes (plus the finder as suggested by @schmittjoh)