Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.11 and return (un)suppressed findings #19

Conversation

mlflr
Copy link
Contributor

@mlflr mlflr commented Oct 1, 2024

This PR has 2 changes:

  • Migrate to Python 3.11 since 3.8 will be EOL
  • Instead of returning a boolean showing success/failure returns a tuple returning the same boolean and a list of (un)suppressed findings
    • Unit Tests now verify results using the output instead of arguments of mocked calls

Note: the library works on 3.12, but Prospector (linter) does not. There are PRs open to fix those issues, but the main maintainer is not responding and other collaborators don't want to approve them due to lack of knowledge...

@mlflr mlflr changed the title Python 3.12 and return (un)suppressed findings Python 3.11 and return (un)suppressed findings Oct 2, 2024
@mlflr mlflr closed this Oct 2, 2024
@mlflr mlflr deleted the feature/python312-and-return-suppressed-findings branch October 2, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant