-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete unused code, implemented core codebase #2
Merged
+1,411
−471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
383db62
to
1b4c1ba
Compare
Loading status checks…
1b4c1ba
to
df89981
Compare
e24998e
to
096ebf5
Compare
096ebf5
to
363b2e9
Compare
f32dee6
to
1576ab7
Compare
# Conflicts: # awsfindingsmanagerlib/awsfindingsmanagerlib.py
…ake Rule comparable.
Loading status checks…
…ith the information about allowed and denied account IDs.
Loading status checks…
…on Rule (Sadly doing it on schema gets too complex as it is not natively supported as a feature). Expose attributes of match rules on Rule object.
Loading status checks…
…abel and strict mode on/off for suppression of finding by payload.
… attributes. Move validation of match_on rules to validation module. Prepare for backends support.
Loading status checks…
…en http backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.