Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Global Database support #61

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

fatbasstard
Copy link
Contributor

@fatbasstard fatbasstard commented Dec 31, 2024

This PR adds support for Aurora Global Database.

Introduced 2 new variables to support the creation of a "Global Database":

  • global_database_primary (bool): If specified a "global database cluster" is created and the cluster is added to it.
  • global_database_secondary (object): If specified, the cluster is added to the Global Database (using the global_cluster_identifier which can be fetched from the outputs of the primary (only the primary)).

Variable validation is added to ensure/handle some requirements and limitations.

Some notable other changes:

  • Refactored the mcaf-role module (used for Enhanced Monitoring) to use the Terraform Registry

Example:
The following setup is created with this module during development:
image

Documentation and Links:

@github-actions github-actions bot added the feature New feature or request label Dec 31, 2024
Copy link
Contributor

github-actions bot commented Dec 31, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️``

Terraform Lint 📖success

Terraform Validation 🤖success

Validation Output


Warning: Argument is deprecated

  with module.vpc.aws_eip.nat,
  on .terraform/modules/vpc/main.tf line 1044, in resource "aws_eip" "nat":
1044:   vpc = true

use domain attribute instead
Success! The configuration is valid, but there were some validation warnings
as shown above.


@fatbasstard fatbasstard force-pushed the fvb/global-database branch 4 times, most recently from 3066ff5 to c87eb52 Compare December 31, 2024 13:52
@fatbasstard fatbasstard merged commit 58eec9d into master Jan 6, 2025
7 checks passed
@fatbasstard fatbasstard deleted the fvb/global-database branch January 6, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants