-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: account variable set #55
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Format and Style 🖌
|
Oh, this entire change is dependent on schubergphilis/terraform-aws-mcaf-workspace#62. I've pinned on the git hash |
gitbluf
reviewed
Jul 26, 2024
Updated the OP to reflect that this PR isn't a hybrid anymore, it changes the default behavior. ☝️. |
…pass it down to all workspaces. Additionally allow you to pipe through other variable set ids to attach.
jorrite
force-pushed
the
environment_variable_sets
branch
from
August 5, 2024 11:21
b44cda7
to
c1b92e7
Compare
marwinbaumannsbp
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
The net result here is a lot of less resources. With the following example: 20 workspaces, 4 environments (accounts), 4 variables:
Additionally, variables and an output is provider to add more variables to the same account variable set. The variables are there for things you know up front, the output is there for variables that might have values that relate to things you provision inside the accounts.